Fix missing logo on visa letters #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timiwahalahti
added
[Priority] 1
[Component] Docs
iandunn
reviewed
Oct 9, 2023
public_html/wp-content/plugins/wordcamp-docs/classes/class-wordcamp-docs-pdf-generator.php
Show resolved
Hide resolved
iandunn
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated attendee and speaker visa letters didn't have the WPCS logo on them as intended. Fixed this by allowing wkhtmltopdf to access local files.
From wkhtmltopdf docs
Fixes #786
Props kdrewien, kcristiano, @yoga1103
Screenshots
How to test the changes in this Pull Request: